[ 
https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008784#comment-15008784
 ] 

Vasia Kalavri commented on FLINK-3002:
--------------------------------------

No, in fact, I didn't go with the abstract version :-)
I do think Either should be abstract, but the Serializer needs to create an 
instance somehow.
I could remove the flags, just I think they're more user-friendly than 
getClass().
Also, when testing, I realized that {{copy}} and {{deserialize}} cannot use the 
{{reuse}} record if it's created with the empty Either constructor. Any ideas 
there? I have pushed the tests in the same branch.
I'll fix the arity, thanks!


> Add an EitherType to the Java API
> ---------------------------------
>
>                 Key: FLINK-3002
>                 URL: https://issues.apache.org/jira/browse/FLINK-3002
>             Project: Flink
>          Issue Type: New Feature
>          Components: Java API
>    Affects Versions: 0.10.0
>            Reporter: Stephan Ewen
>            Assignee: Vasia Kalavri
>             Fix For: 1.0.0
>
>
> Either types are recurring patterns and should be serialized efficiently, so 
> it makes sense to add them to the core Java API.
> Since Java does not have such a type as of Java 8, we would need to add our 
> own version.
> The Scala API handles the Scala Either Type already efficiently. I would not 
> use the Scala Either Type in the Java API, since we are trying to get the 
> {{flink-java}} project "Scala free" for people that don't use Scala and o not 
> want to worry about Scala version matches and mismatches.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to