libenchao commented on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi… URL: https://github.com/apache/flink/pull/10737#issuecomment-570881019 @JingsongLi @wuchong I go over the implementation again, and find that it indeed has many corner cases. - I changed `TableConfig.maxGeneratedCodeLength` to 1, and run all the tests in blink planner, **762/6117** tests failed. - For comparison, I did the same thing to old planner, and found **21/2321** tests failed. So, it's indeed not easy to do code split currently. And I propose to narrow down the scope of this simple fix, which just targets long projection list. Then we can just focus on `CalcCodeGenerator` and add a param `allowSplit` to `ExprCodeGenerator.generateResultExpression`. What's your opinion?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
