[
https://issues.apache.org/jira/browse/FLINK-15471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008530#comment-17008530
]
Yangze Guo commented on FLINK-15471:
------------------------------------
You are right. we'll never go into the block of this if statement.
Meanwhile, I think the usage of check_logs_for_non_empty_out_files in
test-runner-common.sh#post_test_validation is so confusing and error-prone.
Thus, we could change the contract of these check_logs_for_xxx function, fail
the function and print the error log directly. WDYT?
> HA e2e check for empty .out files does not print specific error
> ---------------------------------------------------------------
>
> Key: FLINK-15471
> URL: https://issues.apache.org/jira/browse/FLINK-15471
> Project: Flink
> Issue Type: Improvement
> Components: Test Infrastructure
> Affects Versions: 1.9.0
> Reporter: Chesnay Schepler
> Priority: Major
> Fix For: 1.9.2, 1.10.0
>
>
> {{common_ha.sh#verify_logs:}}
> {code}
> if ! check_logs_for_non_empty_out_files; then
> echo "FAILURE: Alerts found at the general purpose job."
> EXIT_CODE=1
> fi
> {code}
> Since check_logs_for_non_empty_out_files does only set EXIT_CODE without
> modifying the return value the check will never fail.
> While the test will still fail (since EXIT_CODE is later being evaluated), we
> may not actually print the error cause.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
