tillrohrmann commented on a change in pull request #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#discussion_r363245985
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -688,4 +674,47 @@ public static Configuration
adjustConfigurationForLocalExecution(final Configura
return modifiedConfig;
}
+
+ public static Configuration
getConfigurationMapLegacyTaskManagerHeapSizeToConfigOption(
+ final Configuration configuration, ConfigOption<MemorySize>
configOption) {
+
+ if (configuration.contains(configOption)) {
+ return configuration;
+ }
+
+ return
getLegacyTaskManagerHeapMemoryIfExplicitlyConfigured(configuration).map(legacyHeapSize
-> {
+ final Configuration copiedConfig = new
Configuration(configuration);
+ copiedConfig.set(configOption, legacyHeapSize);
+ LOG.info("'{}' is not specified, use the configured
deprecated task manager heap value for it.", configOption.key());
Review comment:
could add `legacyHeapSize` to logging statement to see what the value is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
