GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/1370
[FLINK-3036] [gelly] Fix Graph.fromCsvReader method in Gelly's Scala API
The Graph.fromCsvReader in Gelly's Scala API returns a wrongly typed Graph
instance because
the implementation contains code paths with return types which are not
compatible. This
lead to a bad user experience.
This commit fixes this. However, it also introduces a slightly different
behaviour and is
thus API breaking. Before there were parameters hasEdgeValues and
readVertices which
controlled whether edge values and vertices shall be read. This is now
implicitly controlled
by the types of the vertex and edge value. If the type is NullValue for the
edge values then
the edge value won't be read from the given csv file. If the vertex value
type is NullValue,
then all vertices will have a value of a NullValue instance. If the
pathVertices is not
specified and the vertex value type is unequal to NullValue, then the
vertexValueInitializer
is used for the initialization.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixGelly
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1370.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1370
----
commit 2edec702ceac62ff8bbcdf7b6dda8f029d5f2bea
Author: Till Rohrmann <[email protected]>
Date: 2015-11-17T17:21:47Z
[FLINK-3036] [gelly] Fix Graph.fromCsvReader method in Gelly's Scala API
The Graph.fromCsvReader in Gelly's Scala API returns a wrongly typed Graph
instance because
the implementation contains code paths with return types which are not
compatible. This
lead to a bad user experience.
This commit fixes this. However, it also introduces a slightly different
behaviour and is
thus API breaking. Before there were parameters hasEdgeValues and
readVertices which
controlled whether edge values and vertices shall be read. This is now
implicitly controlled
by the types of the vertex and edge value. If the type is NullValue for the
edge values then
the edge value won't be read from the given csv file. If the vertex value
type is NullValue,
then all vertices will have a value of a NullValue instance. If the
pathVertices is not
specified and the vertex value type is unequal to NullValue, then the
vertexValueInitializer
is used for the initialization.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
