TisonKun commented on a change in pull request #7314: [FLINK-11135][YARN]
Refactor Hadoop config loading in HadoopUtils
URL: https://github.com/apache/flink/pull/7314#discussion_r363640325
##########
File path:
flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/util/HadoopUtils.java
##########
@@ -143,4 +142,24 @@ public static boolean isMinHadoopVersion(int major, int
minor) throws FlinkRunti
return maj > major || (maj == major && min >= minor);
}
+
+ /**
+ * Search Hadoop configuration files in the given path, and add them to
the configuration if found.
+ */
+ private static boolean addHadoopConfIfFound(Configuration
configuration, String possibleHadoopConfPath) {
+ boolean foundHadoopConfiguration = false;
Review comment:
nit: you can inline the variable as `return true`/`return false` instead of
introducing a mutable variable just for return a value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
