tillrohrmann commented on a change in pull request #10788:
[FLINK-15483][kubernetes] Starting jobmanager pod should respect environment
config option
URL: https://github.com/apache/flink/pull/10788#discussion_r363778572
##########
File path:
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/Fabric8ClientTest.java
##########
@@ -187,6 +188,9 @@ public void testCreateFlinkMasterDeployment() {
assertEquals(new File(mountPath, FLINK_CONF_FILENAME).getPath(),
jmContainer.getVolumeMounts().get(0).getMountPath());
assertEquals(FLINK_CONF_FILENAME,
jmContainer.getVolumeMounts().get(0).getSubPath());
+
+ assertEquals(1, jmContainer.getEnv().size());
+ assertEquals(new EnvVar(FLINK_MASTER_ENV_KEY,
FLINK_MASTER_ENV_VALUE, null), jmContainer.getEnv().get(0));
Review comment:
I think this can be expressed more succinctly by using
`assertThat(jmContainer.getEnv(), contains(new EnvVar(FLINK_MASTER_ENV_KEY,
FLINK_MASTER_ENV_VALUE, null)))`;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
