walterddr commented on a change in pull request #9576: [FLINK-13915][ml] Add several base classes of summarizer. URL: https://github.com/apache/flink/pull/9576#discussion_r363891440
########## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/operator/common/statistics/basicstatistic/BaseSummarizer.java ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.flink.ml.operator.common.statistics.basicstatistic; + +import org.apache.flink.ml.common.linalg.DenseMatrix; + +import java.io.Serializable; + +/** + * Summarizer is the base class to calculate summary and store intermediate results, and Summary is the result of Summarizer. + * + * <p>Summarizer Inheritance relationship as follow: + * BaseSummarizer + * / \ + * / \ + * TableSummarizer BaseVectorSummarizer + * / \ + * / \ + * SparseVectorSummarizer DenseVectorSummarizer + * + * <p>TableSummarizer is for table data, BaseVectorSummarizer is for vector data. + * SparseVectorSummarizer is for sparse vector, DenseVectorSummarizer is for dense vector. + * + * <p>Summary Inheritance relationship as follow: Review comment: ```suggestion * <p>Summary is the result of Summarizer. {@link BaseSummary} is the base class of summaries. * * <p>Summary Inheritance relationship as follow: ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
