becketqin commented on a change in pull request #10724:
[FLINK-13595][connector/kafka][test] Close the KafkaAdminClient with ...
URL: https://github.com/apache/flink/pull/10724#discussion_r364518024
##########
File path:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironment.java
##########
@@ -201,4 +202,15 @@ protected NetworkFailuresProxy createProxy(String
remoteHost, int remotePort) {
networkFailuresProxies.add(proxy);
return proxy;
}
+
+ protected void maybePrintDanglingThreadStacktrace(String
threadNameKeyword) {
Review comment:
I think our goal is to make our tests stable, regardless of whether the bug
is in Kafka or not. Adding this log is not only for debugging Kafka.
A dangling thread may not necessarily indicate a bug in Kafka. We don't know
yet. For example, the blocking could be caused by our test environment setting,
e.g. forget to unblock the broker traffic in some case.
Even if it is a bug in Kafka, it is better to know what exactly the bug is
so we know the consequence of it. For example, in this case a topic may not be
deleted, which may have impact in other tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
