gaoyunhaii commented on issue #10736: [FLINK-15010][Network] Add shutdown hook to ensure cleanup netty shuffle directories URL: https://github.com/apache/flink/pull/10736#issuecomment-572362847 Hi @zhijiangW , very thanks for the review. The reason that we cannot directly add shutdown hook to `NettyShuffleEnvironment`, it cannot ensure the directories get cleaned up in all cases, since the directories are created in the constructor of `FileChannelManagerImpl`, which comes before registering shutdown hook in `NettyShuffleEnvironment's` constructor. If task managers receive SIG_TERM between the two actions, the directories will not be cleaned. Currently `IOManager` also has this problem. Therefore, it should be better to directly register shutdown hook for `FileChannelManagerImpl`, before the directories are actually created.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
