xintongsong commented on a change in pull request #10804: [FLINK-15488] Obtain
the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364613032
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -606,25 +606,33 @@ runBashJavaUtilsCmd() {
local class_path=$2
local conf_dir=$3
- local output="`${JAVA_RUN} -classpath ${class_path}
org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2>
/dev/null`"
+ local output=`${JAVA_RUN} -classpath ${class_path}
org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2>
/dev/null | tail -n 1`
Review comment:
In addition, I think we should add another test case to validate the
`BashJavaUtils` works well when there are other noises in the outputs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
