[
https://issues.apache.org/jira/browse/FLINK-15523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17011638#comment-17011638
]
Andrey Zagrebin commented on FLINK-15523:
-----------------------------------------
ConfigConstants.YARN_MAX_FAILED_CONTAINERS is tracked by FLINK-15536
ConfigConstants.TASK_MANAGER_MEMORY_SIZE_KEY is now
TaskManagerOptions.MANAGED_MEMORY_SIZE as a deprecated key so it should be also
deprecated.
All other options have to be deprecated and they have no effect anymore at all.
If we add them back it makes sense to note this in the comments.
ConfigConstants.TASK_MANAGER_MEMORY_FRACTION_KEY is substituted by
TaskManagerOptions.MANAGED_MEMORY_FRACTION but w/o keeping it as a deprecated
key because the new option has similar but different semantics.
> ConfigConstants generally excluded from japicmp
> -----------------------------------------------
>
> Key: FLINK-15523
> URL: https://issues.apache.org/jira/browse/FLINK-15523
> Project: Flink
> Issue Type: Bug
> Components: Build System
> Affects Versions: 1.8.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Blocker
> Fix For: 1.10.0
>
>
> It appears that {{ConfigConstants}}, despite being {{@Public}}, has been
> excluded from the japicmp check since {{1.5.0}}:
> [https://github.com/apache/flink/commit/1f9c2d9740ffea2b59b8f5f3da287a0dc890ddbf]
> This is a bit of a surprise to me and looks like a mistake (what's the point
> of excluding specific fields if the entire class is excluded), and if so this
> has repercussions on some ongoing work:
> {code:java}
> Breaking the build because there is at least one incompatibility:
> org.apache.flink.configuration.ConfigConstants.TASK_MANAGER_MEMORY_SIZE_KEY:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.TASK_MANAGER_MEMORY_OFF_HEAP_KEY:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.DEFAULT_TASK_MANAGER_MEMORY_PRE_ALLOCATE:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.TASK_MANAGER_MEMORY_PRE_ALLOCATE_KEY:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.TASK_MANAGER_MEMORY_FRACTION_KEY:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.YARN_MAX_FAILED_CONTAINERS:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.DEFAULT_MEMORY_MANAGER_MEMORY_FRACTION:FIELD_REMOVED
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
