pnowojski commented on a change in pull request #10816: [Flink-15355] Fixed
parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#discussion_r364749735
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -25,6 +25,9 @@
import org.apache.flink.configuration.description.Description;
import org.apache.flink.util.ArrayUtils;
+import org.apache.flink.shaded.guava18.com.google.common.base.Splitter;
+import org.apache.flink.shaded.guava18.com.google.common.collect.Iterables;
Review comment:
I think the decision is that we shouldn't be adding more guava
dependencies/usages in our code base. At least that's the feedback once I tried
to pull out the same trick you did ("guava already present, so why not to use
it?").
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
