GJL commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM
and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364784352
##########
File path: flink-dist/src/test/java/org/apache/flink/dist/JavaBashTestBase.java
##########
@@ -49,12 +48,6 @@ protected String executeScript(final String[] command)
throws IOException {
ProcessBuilder pb = new ProcessBuilder(command);
pb.redirectErrorStream(true);
Process process = pb.start();
- BufferedReader reader = new BufferedReader(new
InputStreamReader(process.getInputStream()));
- StringBuilder sb = new StringBuilder();
- String s;
- while ((s = reader.readLine()) != null) {
- sb.append(s);
- }
- return sb.toString();
+ return IOUtils.toString(process.getInputStream());
Review comment:
Should have been a separate commit but you don't need to fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
