zhuzhurk opened a new pull request #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED URL: https://github.com/apache/flink/pull/10825 ## What is the purpose of the change In JobResult#createFrom it sets the latest global failure cause of the ExecutionGraph to be the cause of the JobResult if the job is terminated but not FINISHED. So if the job is CANCELED and any global failure had ever happened, the latest global failure cause would be shown as the root cause of the canceling. This results in a misleading root cause exception when a user cancels the job. ## Brief change log - *Changed JobResult to take ExecutionGraph failure cause as its failure cause only if the job is FAILED* - *also checked the failure cause to be not null if a job is FAILED* ## Verifying this change This change added tests and can be verified as follows: - *Fixed testCancelledJobThrowsJobCancellationException* - *Added testFailureResultRequiresFailureCause* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
