curcur opened a new pull request #10832: [FLINK-14163][runtime]Enforce 
synchronous registration of Execution#producedPartitions
URL: https://github.com/apache/flink/pull/10832
 
 
   ## What is the purpose of the change
   
   `Execution#producedPartitions` are registered through an asynchronous 
interface `ShuffleMaster#registerPartitionWithProducer` to `ShuffleMaster`, 
however they are not always accessed through callbacks. So, it is possible that 
`Execution#producedPartitions` have not been available yet when accessed (in 
`Execution#deploy` for example). Since the only implementation of 
`ShuffleMaster` is `NettyShuffleMaster`, which indeed registers 
producedPartition in a synchronous way, hence this pull request enforces 
synchronous registrations under an asynchronous interface as a temporary fix to 
prevent future misuses.
   
   ## Brief change log
   Make sure the future of registration is done immediately after registration. 
Throws IllegalStateException otherwise.
   
   ## Verifying this change
   unit test: 
   ExecutionTest#testSynchronousRegisterProducedPartitions
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? JavaDocs
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to