[
https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010986#comment-15010986
]
ASF GitHub Bot commented on FLINK-3002:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45199167
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/EitherTypeInfo.java
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.api.java.typeutils;
+
+import org.apache.flink.api.common.ExecutionConfig;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.api.java.typeutils.runtime.EitherSerializer;
+
+/**
+ * A {@link TypeInformation} for the {@link Either} type of the Java API.
+ *
+ * @param <L> the Left value type
+ * @param <R> the Right value type
+ */
+public class EitherTypeInfo<L, R> extends TypeInformation<Either<L, R>> {
+
+ private static final long serialVersionUID = 1L;
+
+ private final Class<Either<L, R>> typeClass;
+
+ private final TypeInformation<L> leftType;
+
+ private final TypeInformation<R> rightType;
+
+ @SuppressWarnings({ "unchecked", "rawtypes" })
+ public EitherTypeInfo(Class<Either> typeClass,
+ TypeInformation<L> leftType,TypeInformation<R>
rightType) {
+ this.typeClass = (Class<Either<L, R>>) (Class<?>) typeClass;
+ this.leftType = leftType;
+ this.rightType = rightType;
+ }
+
+ @Override
+ public boolean isBasicType() {
+ return false;
+ }
+
+ @Override
+ public boolean isTupleType() {
+ return false;
+ }
+
+ @Override
+ public int getArity() {
+ return 1;
+ }
+
+ @Override
+ public int getTotalFields() {
+ return 1;
+ }
+
+ @Override
+ public Class<Either<L, R>> getTypeClass() {
+ return this.typeClass;
--- End diff --
I would change this to `return (Class<Either<L, R>>) (Class<?>)
Either.class`. You can then get rid of the field `this.typeClass`.
> Add an EitherType to the Java API
> ---------------------------------
>
> Key: FLINK-3002
> URL: https://issues.apache.org/jira/browse/FLINK-3002
> Project: Flink
> Issue Type: New Feature
> Components: Java API
> Affects Versions: 0.10.0
> Reporter: Stephan Ewen
> Assignee: Vasia Kalavri
> Fix For: 1.0.0
>
>
> Either types are recurring patterns and should be serialized efficiently, so
> it makes sense to add them to the core Java API.
> Since Java does not have such a type as of Java 8, we would need to add our
> own version.
> The Scala API handles the Scala Either Type already efficiently. I would not
> use the Scala Either Type in the Java API, since we are trying to get the
> {{flink-java}} project "Scala free" for people that don't use Scala and o not
> want to worry about Scala version matches and mismatches.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
