zhuzhurk commented on a change in pull request #10832:
[FLINK-14163][runtime]Enforce synchronous registration of
Execution#producedPartitions
URL: https://github.com/apache/flink/pull/10832#discussion_r365721185
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMaster.java
##########
@@ -31,6 +31,10 @@
/**
* Asynchronously register a partition and its producer with the
shuffle service.
*
+ * <p>IMPORTANT: Please implement the asynchronous interface in a
synchronous way.
+ * The default scheduler only supports synchronous registration for now.
+ * Please refer to {@link
NettyShuffleMaster#registerPartitionWithProducer} for example.
Review comment:
I'd prefer to state that "one must return a completed future at the moment".
It is clear enough so the user do need to refer to NettyShuffleMaster for the
implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
