[
https://issues.apache.org/jira/browse/FLINK-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014799#comment-17014799
]
Zhu Zhu commented on FLINK-15307:
---------------------------------
The legacy failover strategies will be removed in 1.11, which means most of the
classes you change will be removed.
So I think it's better to only change the non-legacy(flip1) failover
strategies which will be be kept.
B.T.W I had a glance of the PR and looks to me it does not follow the name
patterns discussed above.
cc: [~gjy]
> Subclasses of FailoverStrategy are easily confused with implementation
> classes of RestartStrategy
> -------------------------------------------------------------------------------------------------
>
> Key: FLINK-15307
> URL: https://issues.apache.org/jira/browse/FLINK-15307
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Configuration
> Reporter: Andrew.D.lin
> Assignee: Andrew.D.lin
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Attachments: image-2019-12-18-14-59-03-181.png
>
> Time Spent: 10m
> Remaining Estimate: 24h
>
> Subclasses of RestartStrategy
> * FailingRestartStrategy
> * FailureRateRestartStrategy
> * FixedDelayRestartStrategy
> * InfiniteDelayRestartStrategy
> Implementation class of FailoverStrategy
> * AdaptedRestartPipelinedRegionStrategyNG
> * RestartAllStrategy
> * RestartIndividualStrategy
> * RestartPipelinedRegionStrategy
>
> FailoverStrategy describes how the job computation recovers from task
> failures.
> I think the following names may be easier to understand and easier to
> distinguish：
> Implementation class of FailoverStrategy
> * AdaptedPipelinedRegionFailoverStrategyNG
> * FailoverAllStrategy
> * FailoverIndividualStrategy
> * FailoverPipelinedRegionStrategy
> FailoverStrategy is currently generated by configuration. If we change the
> name of the implementation class, it will not affect compatibility.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
