JingsongLi commented on a change in pull request #10839:
[FLINK-15567][table][docs] Add documentation for INSERT statements for Flink SQL
URL: https://github.com/apache/flink/pull/10839#discussion_r366131547
##########
File path: docs/dev/table/sql/insert.md
##########
@@ -125,20 +125,28 @@ part_spec:
### Examples
{% highlight sql %}
-
-- Creates a partitioned table
CREATE TABLE country_page_view (user STRING, cnt INT, date STRING, country
STRING)
PARTITIONED BY (date, country)
WITH (...)
--- Appends rows into the partition (date='2019-8-30', country='China')
+-- Appends rows into the static partition (date='2019-8-30', country='China')
INSERT INTO country_page_view PARTITION (date='2019-8-30', country='China')
SELECT user, cnt FROM page_view_source;
--- Overwrites the partition (date='2019-8-30', country='China') using rows in
page_view_source
+-- Appends rows into partition (date, country), where date is static partition
with value '2019-8-30',
+-- country is dynamic partition whose value is dynamic determined by each row.
INSERT INTO country_page_view PARTITION (date='2019-8-30', country='China')
Review comment:
Remove `, country='China'`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
