zhuzhurk commented on a change in pull request #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#discussion_r366143882
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ContinuousFileProcessingCheckpointITCase.java
##########
@@ -77,9 +77,9 @@
@Before
public void createHDFS() throws IOException {
if
(failoverStrategy.equals(FailoverStrategy.RestartPipelinedRegionStrategy)) {
- // TODO the 'NO_OF_RETRIES' is useless for current
RestartPipelinedRegionStrategy,
- // for this ContinuousFileProcessingCheckpointITCase,
using RestartPipelinedRegionStrategy would result in endless running.
- throw new AssumptionViolatedException("ignored
ContinuousFileProcessingCheckpointITCase when using
RestartPipelinedRegionStrategy");
+ // TODO the 'NO_OF_RETRIES' is useless for current
RestartPipelinedRegionFailoverStrategy,
Review comment:
This is actually not `flip. RestartPipelinedRegionStrategy ` but
`StreamFaultToleranceTestBase#FailoverStrategy`.
I think we need to rename the enums in it as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
