[
https://issues.apache.org/jira/browse/FLINK-15582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014975#comment-17014975
]
Zhu Zhu commented on FLINK-15582:
---------------------------------
[~trohrmann] this is a pre-requisite for removing LegacyScheduler but I think
it is also a needed test for DefaultScheduler in 1.10.
To be detailed, I plan to extract most of the codes in
{{LegacySchedulerBatchSchedulingTest}} to a {{BatchSchedulingTestBase}} and
then let the implementations {{LegacySchedulerBatchSchedulingTest}} and
{{DefaultSchedulerBatchSchedulingTest}} implement the {{createScheduler(...)}}
method only. So later when removing the LegacyScheduler we can just remove
{{LegacySchedulerBatchSchedulingTest}} as well.
WDYT?
> Enable batch scheduling tests in LegacySchedulerBatchSchedulingTest for
> DefaultScheduler as well
> ------------------------------------------------------------------------------------------------
>
> Key: FLINK-15582
> URL: https://issues.apache.org/jira/browse/FLINK-15582
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Coordination
> Affects Versions: 1.10.0
> Reporter: Zhu Zhu
> Priority: Major
> Fix For: 1.10.0
>
>
> {{testSchedulingOfJobWithFewerSlotsThanParallelism}} is a common case but it
> is only tested with legacy scheduler in
> {{LegacySchedulerBatchSchedulingTest}} at the moment.
> We should enable it for DefaultScheduler as well.
> This also allows us to safely remove {{LegacySchedulerBatchSchedulingTest}}
> when we are removing the LegacyScheduler and related components without
> loosing test coverage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
