tillrohrmann commented on a change in pull request #10754: 
[FLINK-14091][coordination] Allow updates to connection state when 
ZKCheckpointIDCounter reconnects to ZK
URL: https://github.com/apache/flink/pull/10754#discussion_r366362475
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCheckpointIDCounter.java
 ##########
 @@ -149,6 +150,11 @@ public void setCount(long newId) throws Exception {
                sharedCount.setCount((int) newId);
        }
 
+       @VisibleForTesting
+       ConnectionState getLastState() {
+               return connStateListener.lastState;
+       }
 
 Review comment:
   I think this exposes internal details which are not relevant for the test. I 
would try to write the test without exposing these internals.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to