zhuzhurk commented on a change in pull request #10832: 
[FLINK-14163][runtime]Enforce synchronous registration of 
Execution#producedPartitions
URL: https://github.com/apache/flink/pull/10832#discussion_r366681405
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphTestUtils.java
 ##########
 @@ -398,6 +401,10 @@ public static JobVertex createJobVertex(String task1, int 
numTasks, Class<NoOpIn
                return groupVertex;
        }
 
+       public static ExecutionJobVertex getExecutionVertex(JobVertexID id) 
throws Exception {
 
 Review comment:
   I know that ExecutionGraphTestUtils did have several `getExecutionVertex 
(...)` methods to map `JobVertexID` to `ExecutionJobVertex `, but I think it's 
better we rename the old and newly added ones to `getExecutionJobVertex (...)`. 
Because `ExecutionVertex` is a structure different from `ExecutionJobVertex`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to