pnowojski commented on a change in pull request #10824:
[FLINK-15152][checkpointing] Restatrt CheckpointCoordinator if
StopWithSavepoint failed
URL: https://github.com/apache/flink/pull/10824#discussion_r366875446
##########
File path:
flink-tests/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterStopWithSavepointIT.java
##########
@@ -357,4 +391,36 @@ public void finishTask() throws Exception {
finishLatch.trigger();
}
}
+
+ /**
+ * A {@link StreamTask} that simply calls {@link
CountDownLatch#countDown()} when
+ * invoking {@link #triggerCheckpointAsync}.
+ */
+ public static class CheckpointCountingTask extends NoOpStreamTask {
Review comment:
By extracting I meant that `ExceptionOnCallbackStreamTask` could also use
this `CheckpointCountingTask` class to avoid some (minor) code duplication.
Could you re-use this code in `ExceptionOnCallbackStreamTask`? Make it extend
`CheckpointCountingTask` and delegate methods/constructors to `super` calls?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
