aljoscha commented on a change in pull request #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector URL: https://github.com/apache/flink/pull/10861#discussion_r367363001
########## File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE ########## @@ -15,31 +15,33 @@ This project bundles the following dependencies under the Apache Software Licens - org.apache.httpcomponents:httpasyncclient:4.1.4 - org.apache.httpcomponents:httpclient:4.5.3 - org.apache.httpcomponents:httpcore:4.4.6 -- org.apache.httpcomponents:httpcore-nio:4.4.11 +- org.apache.httpcomponents:httpcore-nio:4.4.12 - org.apache.logging.log4j:log4j-api:2.11.1 - org.apache.logging.log4j:log4j-to-slf4j:2.11.1 -- org.apache.lucene:lucene-analyzers-common:8.1.0 -- org.apache.lucene:lucene-backward-codecs:8.1.0 -- org.apache.lucene:lucene-core:8.1.0 -- org.apache.lucene:lucene-grouping:8.1.0 -- org.apache.lucene:lucene-highlighter:8.1.0 -- org.apache.lucene:lucene-join:8.1.0 -- org.apache.lucene:lucene-memory:8.1.0 -- org.apache.lucene:lucene-misc:8.1.0 -- org.apache.lucene:lucene-queries:8.1.0 -- org.apache.lucene:lucene-queryparser:8.1.0 -- org.apache.lucene:lucene-sandbox:8.1.0 -- org.apache.lucene:lucene-spatial:8.1.0 -- org.apache.lucene:lucene-spatial-extras:8.1.0 -- org.apache.lucene:lucene-spatial3d:8.1.0 -- org.apache.lucene:lucene-suggest:8.1.0 -- org.elasticsearch:elasticsearch:7.3.2 -- org.elasticsearch:elasticsearch-cli:7.3.2 -- org.elasticsearch:elasticsearch-core:7.3.2 -- org.elasticsearch:elasticsearch-secure-sm:7.3.2 -- org.elasticsearch:elasticsearch-x-content:7.3.2 -- org.elasticsearch.client:elasticsearch-rest-client:7.3.2 -- org.elasticsearch.client:elasticsearch-rest-high-level-client:7.3.2 -- org.elasticsearch.plugin:aggs-matrix-stats-client:7.3.2 -- org.elasticsearch.plugin:parent-join-client:7.3.2 -- org.elasticsearch.plugin:rank-eval-client:7.3.2 +- org.apache.lucene:lucene-analyzers-common:8.3.0 +- org.apache.lucene:lucene-backward-codecs:8.3.0 +- org.apache.lucene:lucene-core:8.3.0 +- org.apache.lucene:lucene-grouping:8.3.0 +- org.apache.lucene:lucene-highlighter:8.3.0 +- org.apache.lucene:lucene-join:8.3.0 +- org.apache.lucene:lucene-memory:8.3.0 +- org.apache.lucene:lucene-misc:8.3.0 +- org.apache.lucene:lucene-queries:8.3.0 +- org.apache.lucene:lucene-queryparser:8.3.0 +- org.apache.lucene:lucene-sandbox:8.3.0 +- org.apache.lucene:lucene-spatial:8.3.0 +- org.apache.lucene:lucene-spatial-extras:8.3.0 +- org.apache.lucene:lucene-spatial3d:8.3.0 +- org.apache.lucene:lucene-suggest:8.3.0 +- org.elasticsearch:elasticsearch:7.5.1 +- org.elasticsearch:elasticsearch-cli:7.5.1 +- org.elasticsearch:elasticsearch-core:7.5.1 +- org.elasticsearch:elasticsearch-secure-sm:7.5.1 +- org.elasticsearch:elasticsearch-x-content:7.5.1 +- org.elasticsearch.client:elasticsearch-rest-client:7.5.1 +- org.elasticsearch.client:elasticsearch-rest-high-level-client:7.5.1 +- org.elasticsearch.plugin:aggs-matrix-stats-client:7.5.1 +- org.elasticsearch.plugin:lang-mustache-client:7.5.1 Review comment: Why did you add `mustache-client` here? I think the rest of the dependencies look correct but about this one I don't know. It doesn't appear in the list of jars that are shaded in when I run `mvn clean install -DskipTests -Dfast`. In the ES7 SQL connector module. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
