pnowojski commented on a change in pull request #10332:
[FLINK-13905][checkpointing] Separate checkpoint triggering into several
asynchronous stages
URL: https://github.com/apache/flink/pull/10332#discussion_r367381941
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -163,9 +163,9 @@
* Non-volatile, because only accessed in synchronized scope */
private boolean periodicScheduling;
- /** Flag whether a trigger request could not be handled immediately.
Non-volatile, because only
- * accessed in synchronized scope */
- private boolean triggerRequestQueued;
+ /** Flag whether periodic triggering is suspended (too many concurrent
pending checkpoint).
Review comment:
nit: I think the grammar of the commit message is a bit confusing (what was
in the past and will be in the future).
If I understand it correctly it should be:
```
This is not just a pure renaming. The semantics has been changed a bit.
If there are too many in-flight checkpoints, the current checkpoint
will fail, and the periodic triggering will be suspended. This stays the
same
as it used to be before.
From now on, there will be no queued semantics. If an in-flight checkpoint
ends its lifecycle, it will try to resume periodic triggering, but no
queued checkpoint will be resumed anymore, as it was in the past.
```
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
