zentol commented on a change in pull request #10832:
[FLINK-14163][runtime]Enforce synchronous registration of
Execution#producedPartitions
URL: https://github.com/apache/flink/pull/10832#discussion_r367473190
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -605,6 +606,26 @@ public void setInitialState(@Nullable
JobManagerTaskRestore taskRestore) {
});
}
+ /**
+ * Register producedPartitions to {@link ShuffleMaster}
+ *
+ * <p>HACK: Please notice that this method simulates asynchronous
registration in a synchronous way
+ * by making sure the returned {@link CompletableFuture} from {@link
ShuffleMaster#registerPartitionWithProducer}
+ * is done immediately.
Review comment:
```suggestion
* is completed immediately.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
