zentol commented on a change in pull request #10832:
[FLINK-14163][runtime]Enforce synchronous registration of
Execution#producedPartitions
URL: https://github.com/apache/flink/pull/10832#discussion_r367891697
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMaster.java
##########
@@ -31,6 +31,10 @@
/**
* Asynchronously register a partition and its producer with the
shuffle service.
*
+ * <p>IMPORTANT: the returned future must be completed due to
limitations in the default scheduler.
+ * The default scheduler only supports synchronous registration at the
moment.
Review comment:
This line and the one below effectively do not provide any new information;
I'd remove them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
