tillrohrmann commented on a change in pull request #10682:
[FLINK-15247][Runtime] Wait for all slots to be free before task executor
services shutdown upon stopping
URL: https://github.com/apache/flink/pull/10682#discussion_r368065079
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java
##########
@@ -462,7 +471,7 @@ public int freeSlot(AllocationID allocationId, Throwable
cause) throws SlotNotFo
* @return True if the timeout is valid; otherwise false
*/
public boolean isValidTimeout(AllocationID allocationId, UUID ticket) {
- checkInit();
+ checkStartedOrClosing();
Review comment:
Same here, this might allow a race condition between this method and the
stopping of the `TimerService`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
