lirui-apache commented on a change in pull request #10879: [FLINK-15595][table] Remove CoreMudule in ModuleManager URL: https://github.com/apache/flink/pull/10879#discussion_r368265163
########## File path: docs/dev/table/functions/index.md ########## @@ -84,11 +84,13 @@ The resolution order is: 1. Temporary catalog function 2. Catalog function -## Ambiguous Function Reference +### Ambiguous Function Reference The resolution order is: 1. Temporary system function -2. System function -3. Temporary catalog function, in the current catalog and current database of the session -4. Catalog function, in the current catalog and current database of the session +2. Temporary catalog function, in the current catalog and current database of the session Review comment: I'm also wary about this change. IMHO function resolution order change can break user programs, so we probably need to have a discussion on the mailing list. Besides, I don't see how Module plays its part in the resolution. Is it treated as the `System function`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
