wuchong commented on a change in pull request #10896:
[FLINK-15631][table-planner-blink] Fix equals code generation for raw and
timestamp type
URL: https://github.com/apache/flink/pull/10896#discussion_r368292429
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/EqualiserCodeGenerator.scala
##########
@@ -29,6 +30,10 @@ import scala.collection.JavaConversions._
class EqualiserCodeGenerator(fieldTypes: Seq[LogicalType]) {
+ def this(fieldTypes: Array[LogicalType]) {
Review comment:
Can we improve the existing constructor to accept only Array[] ? So that we
can avoid to maintain two constructors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
