[
https://issues.apache.org/jira/browse/FLINK-15687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019533#comment-17019533
]
Till Rohrmann commented on FLINK-15687:
---------------------------------------
[~yangwang166] do you know whether there is any safeguard in the
{{TaskSubmissionTestEnvironment}} which allows to mutate the {{TaskSlotTable}}
outside of the {{TaskExecutor's}} main thread? If not, then I would suggest to
remove {{TaskSubmissionTestEnvironment#getTaskSlotTable}} altogether and to
rework the affected tests.
> Potential test instabilities due to concurrent access to TaskSlotTable.
> -----------------------------------------------------------------------
>
> Key: FLINK-15687
> URL: https://issues.apache.org/jira/browse/FLINK-15687
> Project: Flink
> Issue Type: Task
> Components: Runtime / Coordination, Tests
> Affects Versions: 1.10.0
> Reporter: Kostas Kloudas
> Priority: Critical
> Labels: test-stability
>
> Working on [FLINK-14742|https://issues.apache.org/jira/browse/FLINK-14742]
> revealed that the problem with that test instability was the modification of
> the {{taskSlotTable}} of the {{TaskManager}} under test from multiple
> threads, namely the test thread and the main thread of the {{rpcEnpoint}}.
> This data-structure is not thread-safe and this should not happen.
> This anti-pattern seems to be repeated in multiple tests like most of the
> tests in the {{TaskExecutorSubmissionTest}} (look for the call to the
> {{TaskSlotTable.allocateSlot()}}). There we seem to call
> {{taskSlotTable.allocateSlot()}} and then \{{tmGateway.submitTask()}} which
> is essentially accessing the slot table from within the main rpc-endpoint
> thread.
> This JIRA is just to investigate if this is also a problem in those tests or
> not.
> cc [~trohrmann], [~chesnay] , [~yangwang166]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
