GJL commented on a change in pull request #10850: [FLINK-15519][configuration]
Preserve logs from BashJavaUtils and make them part of TM logs
URL: https://github.com/apache/flink/pull/10850#discussion_r368549395
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -42,6 +42,26 @@ constructFlinkClassPath() {
echo "$FLINK_CLASSPATH""$FLINK_DIST"
}
+findFlinkDistJar() {
+ local FLINK_DIST
+
+ while read -d '' -r jarfile ; do
Review comment:
Wouldn't it be easier to run one of the following?
```
$ ls lib/flink-dist_*.jar
lib/flink-dist_2.11-1.11-SNAPSHOT.jar
```
or
```
$ find lib -name 'flink-dist*.jar'
lib/flink-dist_2.11-1.11-SNAPSHOT.jar
```
If I understand correctly `FLINK_DIST` should contain only one jar, and
there are no other variables that are updated. Hence, the while loop should not
be needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
