tillrohrmann commented on a change in pull request #10916: [FLINK-15684][docs]
Add taskmanager.memory.flink.size to common options
URL: https://github.com/apache/flink/pull/10916#discussion_r369113423
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -257,20 +257,25 @@
key("taskmanager.memory.process.size")
.memoryType()
.noDefaultValue()
- .withDescription("Total Process Memory size for the
TaskExecutors. This includes all the memory that a"
- + " TaskExecutor consumes, consisting of Total
Flink Memory, JVM Metaspace, and JVM Overhead. On"
- + " containerized setups, this should be set to
the container memory.");
+ .withDescription("Total Process Memory size for the
TaskExecutors. This includes all the memory that a "
+ + "TaskExecutor consumes, consisting of Total
Flink Memory (configured with "
+ + "'taskmanager.memory.flink.size'), JVM
Metaspace, and JVM Overhead. On "
+ + "containerized setups, this should be set to
the container memory."
Review comment:
Adding the parenthesis with the reference to `flink.size` somehow reads as
if one needs to configure this in order to make `process.size` work. I would
rather suggest to add a sentence `See also taskmanager.memory.flink.size for
flink process mmeory size configuration`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
