aljoscha commented on a change in pull request #10925:  
[FLINK-15690][core][configuration] Enable configuring ExecutionConfig & 
CheckpointConfig from flink-conf.yaml
URL: https://github.com/apache/flink/pull/10925#discussion_r369573440
 
 

 ##########
 File path: 
flink-core/src/main/java/org/apache/flink/api/common/cache/DistributedCache.java
 ##########
 @@ -183,6 +187,33 @@ public static void writeFileInfoToConfig(String name, 
DistributedCacheEntry e, C
                return cacheFiles.entrySet();
        }
 
+       /**
 
 Review comment:
   Are the seemingly unrelated changed to cached file configuration in this 
commit because you noticed there was something wrong with it? Might still make 
sense to split it into a separate commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to