dawidwys commented on a change in pull request #10928:
[FLINK-15487][table-common] Make TypeInference mandatory for function
definitions
URL: https://github.com/apache/flink/pull/10928#discussion_r369992703
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/ScalarFunctionDefinition.java
##########
@@ -53,6 +56,11 @@ public FunctionKind getKind() {
return FunctionKind.SCALAR;
}
+ @Override
+ public TypeInference getTypeInference(DataTypeFactory factory) {
Review comment:
nit:
1. The whole class should be `@Internal`
2. Could we add a comment on top of this class that this is a marker
interface to use the old type stack for the function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
