GJL commented on a change in pull request #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default URL: https://github.com/apache/flink/pull/10934#discussion_r370166970
########## File path: docs/dev/stream/state/state.md ########## @@ -511,7 +508,7 @@ You can change it and pass a custom value to `StateTtlConfig.newBuilder(...).cleanupInRocksdbCompactFilter(long queryTimeAfterNumEntries)` method. Updating the timestamp more often can improve cleanup speed but it decreases compaction performance because it uses JNI call from native code. -If you enable the default background cleanup then this strategy will be activated for RocksDB backend and the current timestamp will be queried each time 1000 entries have been processed. +The default background cleanup for RocksDB backend queries the current timestamp each time when 1000 entries have been processed. Review comment: Imo, _"when"_ is not needed. Maybe another alternative that sounds better to me: _[...] queries the current timestamp for every 1000 processed entries_ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
