pnowojski commented on a change in pull request #10943: [FLINK-15751][task] Let
all exceptions propagate from the StreamTask#runMailboxLoop
URL: https://github.com/apache/flink/pull/10943#discussion_r371126747
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -493,8 +493,6 @@ private void runMailboxLoop() throws Exception {
Thread.currentThread().interrupt();
throw interruption.get();
}
- } else if (canceled) {
- LOG.warn("Error while canceling task.", e);
Review comment:
Could it be? There is still need for 3 different branches. Admittedly
branches could be re-order to avoid one level of nesting, but still, how could
they be squashed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
