zentol commented on a change in pull request #3:
[FLINK-15759][FLINK-15757][FLINK-15764] Adjust POM definitions
URL: https://github.com/apache/flink-statefun/pull/3#discussion_r372245754
##########
File path: statefun-flink/pom.xml
##########
@@ -56,13 +56,68 @@ under the License.
<id>apache.snapshots</id>
<name>Apache Development Snapshot Repository</name>
<url>https://repository.apache.org/content/repositories/snapshots/</url>
- <releases><enabled>false</enabled></releases>
- <snapshots><enabled>true</enabled></snapshots>
+ <releases>
+ <enabled>false</enabled>
+ </releases>
+ <snapshots>
+ <enabled>true</enabled>
+ </snapshots>
</repository>
</repositories>
<dependencyManagement>
+ <!-- Flink -->
<dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-streaming-java_2.11</artifactId>
Review comment:
I would heavily recommend also defining the version in here;
DependencyManagement entries without versions are not really intended and can
break in weird ways when plugins try to resolve dependencies.
Depends a bit of course on which plugins you want to use in the future; we
specifically ran into this when using the `japicmp` plugin which verifies API
compatibility; which I suppose we may add in the future(?).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
