tillrohrmann commented on a change in pull request #10886:
[FLINK-15623][checkstyle] Exclude target directory
URL: https://github.com/apache/flink/pull/10886#discussion_r372513221
##########
File path: tools/maven/suppressions.xml
##########
@@ -32,13 +32,6 @@ under the License.
<suppress
files="org[\\/]apache[\\/]beam[\\/]vendor[\\/]grpc[\\/]v1p21p0[\\/]io[\\/]netty[\\/]buffer.*.java"
checks="[a-zA-Z0-9]*"/>
<suppress
files="org[\\/]apache[\\/]beam[\\/]runners[\\/]fnexecution[\\/]environment.*.java"
checks="[a-zA-Z0-9]*"/>
- <!-- Python streaming API follows python naming conventions -->
- <suppress
-
files="org[\\/]apache[\\/]flink[\\/]streaming[\\/]python[\\/]api[\\/].*.java"
- checks="MethodNameCheck|ParameterName"/>
- <suppress
-
files="org[\\/]apache[\\/]flink[\\/]streaming[\\/]python[\\/]connectors[\\/].*.java"
- checks="MethodNameCheck|ParameterName"/>
Review comment:
Why can we remove these suppressions? According to the comment, the Java
Python files follow python naming conventions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
