pnowojski commented on a change in pull request #10435: [FLINK-13955][runtime]
migrate ContinuousFileReaderOperator to the mailbox execution model
URL: https://github.com/apache/flink/pull/10435#discussion_r372898757
##########
File path:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingMigrationTest.java
##########
@@ -135,8 +135,7 @@ public void writeReaderSnapshot() throws Exception {
BlockingFileInputFormat format = new
BlockingFileInputFormat(blockingLatch, new Path(testFolder.getAbsolutePath()));
Review comment:
Could you add
> Performance is lower by ~15% because of the overhead of enqueueing and
processing each mail (instead of just loop).
sentence to the commit message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
