GJL commented on a change in pull request #10965: [FLINK-15797][k8s] Reduce log
noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#discussion_r373067518
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -269,14 +271,14 @@ public void eventReceived(Action action, Pod pod) {
callbackHandler.onDeleted(Collections.singletonList(new
KubernetesPod(flinkConfig, pod)));
break;
default:
- LOG.info("Skip handling {}
event for pod {}", action, pod.getMetadata().getName());
+ LOG.debug("Ignore handling {}
event for pod {}", action, pod.getMetadata().getName());
break;
}
}
@Override
public void onClose(KubernetesClientException e) {
- LOG.error("Pods watcher onClose", e);
+ LOG.debug("The pods watcher is closing.", e);
Review comment:
Not in the scope of this PR but why is it acceptable to omit error handling?
If the connection attempts of the websocket are exhausted, we will stop
watching for changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
