JingsongLi commented on a change in pull request #10960: [FLINK-15487][table]
Update code generation for new type inference
URL: https://github.com/apache/flink/pull/10960#discussion_r373382089
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala
##########
@@ -694,38 +706,67 @@ object CodeGenUtils {
}
}
+ /**
+ * Generates code for converting the given external source data type to the
internal data format.
+ *
+ * Use this function for converting at the edges of the API.
+ */
def genToInternalIfNeeded(
ctx: CodeGeneratorContext,
- t: DataType,
- term: String): String = {
- if (isInternalClass(t)) {
- s"(${boxedTypeTermForType(fromDataTypeToLogicalType(t))}) $term"
+ sourceType: DataType,
+ externalTerm: String)
+ : GeneratedExpression = {
+ // convert external source type to internal format
+ val internalResultTerm = if (isInternalClass(sourceType)) {
+ s"(${boxedTypeTermForType(fromDataTypeToLogicalType(sourceType))})
$externalTerm"
Review comment:
We need this cast because UDF can return `Object` and DataType with internal
conversion class...
Sometimes there is some gap between the conversion class and real java
function return class. It is safe to add this cast, and I think JVM can
optimize this cast to not affect performance.
I think we can add comment here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
