igalshilman commented on a change in pull request #5: [FLINK-15769] [kafka-io]
Add configuring startup position for Kafka ingress
URL: https://github.com/apache/flink-statefun/pull/5#discussion_r373390583
##########
File path:
statefun-kafka-io/src/main/java/org/apache/flink/statefun/sdk/kafka/KafkaIngressSpec.java
##########
@@ -69,4 +75,8 @@ public Properties properties() {
public Class<? extends KafkaIngressDeserializer<T>> deserializerClass() {
return deserializerClass;
}
+
+ public Optional<String> consumerGroupId() {
+ return (consumerGroupId == null) ? Optional.empty() :
Optional.of(consumerGroupId);
Review comment:
This could be replaced with `Optional.ofNullable(consumerGroupdId)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
