[ 
https://issues.apache.org/jira/browse/FLINK-15648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027552#comment-17027552
 ] 

Yang Wang commented on FLINK-15648:
-----------------------------------

[~felixzheng] Could you share the key advantages of separate the request and 
limit configuration? Since it will make kubernetes configuration very different 
from others(standalone, Yarn, mesos).

For cpu, it may be easier. Users could set the limit value bigger than request 
to share some cpu when the machine cpu loads is low.

However for memory, if the limit value is bigger than request, the extra memory 
could only be used by off-heap memory. How do we suggest our users to set the 
limit value?

In fact, in our internal use case, we add a config option to turn off the 
strict resource mode, just like Yarn.
{code:java}
public static final ConfigOption<Boolean> ENABLE_RESOURCE_MEMORY_LIMIT =
 key("kubernetes.enable.resource.memory.limit")
  .defaultValue(true)
  .withDescription("This flag determines whether flink cluster should run with 
strict memory resource limits " +
   "or be allowed to consume spare resources if they need them.");

public static final ConfigOption<Boolean> ENABLE_RESOURCE_CPU_LIMIT =
 key("kubernetes.enable.resource.cpu.limit")
  .defaultValue(false)
  .withDescription("This flag determines whether flink cluster should run with 
strict cpu resource limits " +
  "or be allowed to consume spare resources if they need them.");
{code}
 

> Support to configure request or limit for CPU requirement
> ---------------------------------------------------------
>
>                 Key: FLINK-15648
>                 URL: https://issues.apache.org/jira/browse/FLINK-15648
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Deployment / Kubernetes
>            Reporter: Canbin Zheng
>            Priority: Major
>
> The current branch use kubernetes.xx.cpu to configure request and limit 
> resource requirement for a Container, it's an important improvement to 
> separate these two configurations, we can use kubernetes.xx.request.cpu and 
> kubernetes.xx.limit.cpu to specify request and limit resource 
> requirements.{color:#6a8759}
> {color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to