[ 
https://issues.apache.org/jira/browse/FLINK-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028491#comment-17028491
 ] 

Ayush Saxena commented on FLINK-15838:
--------------------------------------

Well, technically speaking, it could be like that, but as far as present usages 
are concerned, seems won't be that critical, but for sure can be done for 
sanity.

If people agree, we can do that for sure, asserting the output shouldn't hurt

> Dangling CountDownLatch.await(timeout)
> --------------------------------------
>
>                 Key: FLINK-15838
>                 URL: https://issues.apache.org/jira/browse/FLINK-15838
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Roman Leventov
>            Priority: Major
>
> There are 16 occurrences in the codebase (all in test code) when the result 
> of CountDownLatch.await(timeout, TimeUnit) is not checked. It's like not 
> checking the result of File.delete(). The common fix is to wrap CDL.await() 
> call into assertTrue().
> All 16 places could be found using the following structural search in 
> IntelliJ:
> $x$.await($y$, $z$);
> With "CountDownLatch" type constraint on the $x$ variable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to