Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1384#issuecomment-158896082
Hi @rawkintrevo, thanks for your contribution.
You have some scala style violations in `GradientDescent.scala` line 46 and
168. The lines mustn't be longer than 100 characters as the maven log output
indicates.
Furthermore, could you change the title to the format "[FLINK-1994] [ml]
Add different gain calculation schemes to SGD". That way, the JIRA issues will
be automatically updated with the what happens on Github.
In Flink, we always rebase our changes on top of the current master branch.
Therefore, it would be good if you could revert the last merge commit. If you
want to update on the latest master, then do a rebase and a force push to the
branch in your repository (here `master`).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
