JingsongLi commented on a change in pull request #10989: 
[FLINK-15840][table-planner-blink] ClassCastException is thrown when use 
tEnv.from for temp/catalog table
URL: https://github.com/apache/flink/pull/10989#discussion_r373895481
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/calcite/ToRexConverterFactory.java
 ##########
 @@ -18,26 +18,11 @@
 
 package org.apache.flink.table.planner.calcite;
 
-import org.apache.calcite.plan.RelOptTable;
 import org.apache.calcite.rel.type.RelDataType;
 
 /**
- * A ToRelContext impl that takes the context variables
- * used for sql expression transformation.
+ * Factory to create {@link SqlExprToRexConverter}.
  */
-public interface FlinkToRelContext extends RelOptTable.ToRelContext {
-
-       /**
-        * Creates a new instance of {@link SqlExprToRexConverter} to convert 
sql statements
-        * to {@link org.apache.calcite.rex.RexNode}.
-        *
-        * <p>See {@link 
org.apache.flink.table.planner.plan.schema.FlinkPreparingTableBase#toRel}
-        * for details.
-        */
-       SqlExprToRexConverter createSqlExprToRexConverter(RelDataType 
tableRowType);
-
-       /**
-        * Creates a new instance of {@link FlinkRelBuilder} to build 
relational expressions.
-        */
-       FlinkRelBuilder createRelBuilder();
+public interface ToRexConverterFactory {
 
 Review comment:
   I thought too long... but is OK.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to