danny0405 commented on a change in pull request #10989:
[FLINK-15840][table-planner-blink] ClassCastException is thrown when use
tEnv.from for temp/catalog table
URL: https://github.com/apache/flink/pull/10989#discussion_r373917104
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/delegation/PlannerContext.java
##########
@@ -80,13 +82,15 @@
*/
@Internal
public class PlannerContext {
+
private final RelDataTypeSystem typeSystem = new FlinkTypeSystem();
private final FlinkTypeFactory typeFactory = new
FlinkTypeFactory(typeSystem);
private final TableConfig tableConfig;
- private final RelOptCluster cluster;
private final FlinkContext context;
private final CalciteSchema rootSchema;
private final List<RelTraitDef> traitDefs;
+ private FrameworkConfig frameworkConfig;
+ private RelOptCluster cluster;
Review comment:
The code is a little messy, `FrameworkConfig` reference the `cluster`, while
the `cluster` context have a member that needs a `FrameworkConfig` and the
`cluster` itself ...
We may need to re-think if the `SqlExprToRexConverter` should belong to the
`cluster` context, can we just pass in the `FrameworkConfig` into the context
and constructing the `SqlExprToRexConverter` when we really need that (i.e. the
`CatalogSourceTable`)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
